Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix e2e test ModuleNotFoundError: No module named 'pkg_resources' #1189

Merged
merged 1 commit into from
Dec 7, 2023
Merged

fix e2e test ModuleNotFoundError: No module named 'pkg_resources' #1189

merged 1 commit into from
Dec 7, 2023

Conversation

moshe010
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Nov 20, 2023 •
edited
Loading

Coverage Status

coverage: 63.162%. remained the same
when pulling 9d84deb on moshe010:fix-e2e
into a373a22 on k8snetworkplumbingwg:master.

@moshe010 moshe010 force-pushed the fix-e2e branch 3 times, most recently from 2ff64e8 to 96dcb2e Compare November 20, 2023 12:39
@moshe010 moshe010 mentioned this pull request Nov 20, 2023
Merged
@maiqueb
Copy link
Collaborator

maiqueb commented Nov 20, 2023

/cc @s1061123

@moshe010
Copy link
Contributor Author

@dougbtv can you please review?

@s1061123
Copy link
Member

s1061123 commented Dec 4, 2023

Thank you for the PR and fix CI! I prefer to use j2cli package without replacing package with others.
As far as I test, this change works too. Could you try that?

diff --git a/.github/workflows/kind-e2e.yml b/.github/workflows/kind-e2e.yml
index 165070b6..585104e3 100644
--- a/.github/workflows/kind-e2e.yml
+++ b/.github/workflows/kind-e2e.yml
@@ -45,8 +45,8 @@ jobs:

       - name: Setup j2cli
         run: |
-          pip3 install --user --upgrade j2cli
-          j2 --version
+          sudo apt-get install -y j2cli
+          echo $(j2 --version)

@s1061123
Copy link
Member

s1061123 commented Dec 7, 2023

I'll change that and merge soon.

@s1061123 s1061123 merged commit e4404b2 into k8snetworkplumbingwg:master Dec 7, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maiqueb maiqueb maiqueb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@moshe010 @coveralls @maiqueb @s1061123